netdev - Re: [PATCH 2/2] net: fsl: Fix error checking for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151130.152013.2015081413365508776.davem@davemloft.net>
Date:	Mon, 30 Nov 2015 15:20:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	broonie@...nel.org
Cc:	claudiu.manoil@...escale.com, Shaohui.Xie@...escale.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: fsl: Fix error checking for platform_get_irq()

From: Mark Brown <broonie@...nel.org>
Date: Thu, 26 Nov 2015 11:59:46 +0000

> The gianfar driver has recently been enabled on arm64 but fails to build
> since it check the return value of platform_get_irq() against NO_IRQ. Fix
> this by instead checking for a negative error code.
> 
> Even on ARM where this code was previously being built this check was
> incorrect since platform_get_irq() returns a negative error code which
> may not be exactly the (unsigned int)(-1) that NO_IRQ is defined to be.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html