netdev - Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151129.224031.1377764944004812313.davem@davemloft.net>
Date:	Sun, 29 Nov 2015 22:40:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	anuplimbu14@...il.com
Cc:	mjg59@...f.ucam.org, tklauser@...tanz.com,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc +
 memcpy

From: Anup Limbu <anuplimbu14@...il.com>
Date: Wed, 25 Nov 2015 15:37:21 +0530

> replace kmalloc + memset with kmemdup
> 
> Signed-off-by: Anup Limbu <anuplimbu14@...il.com>

I agree with Bjorn that this microturfing cleanup misses
the real higher level opportunity to use the usbnet_read_cmd()
and usbnet_write_cmd() helpers that already exist.

Over time I am getting more and more weary of laser focused
microscopic cleanups.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html