netdev - Re: [PATCH 1/2] sfc: make TSO version a per-queue parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151129.225041.428082239866177063.davem@davemloft.net>
Date:	Sun, 29 Nov 2015 22:50:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bkenward@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 1/2] sfc: make TSO version a per-queue parameter

From: Bert Kenward <bkenward@...arflare.com>
Date: Wed, 25 Nov 2015 16:06:14 +0000

>  	if (!(nic_data->datapath_caps &
> -	      (1 << MC_CMD_GET_CAPABILITIES_OUT_TX_TSO_LBN))) {
> -		netif_err(efx, drv, efx->net_dev,

Can you please keep code properly indented...

> +
> +	if (nic_data->datapath_caps &
> +			(1 << MC_CMD_GET_CAPABILITIES_OUT_TX_TSO_LBN)) {

when all you are doing is moving it from one place to another?

That first parenthesis on the second line must start exactly at the
first column after the openning parenthesis of the enclosing
if () statement.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html