netdev - Re: [PATCH net] openvswitch: properly refcount vport-vxlan module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Nov 2015 22:56:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pabeni@...hat.com
Cc:	netdev@...r.kernel.org, pshelar@...ira.com, tgraf@...g.ch
Subject: Re: [PATCH net] openvswitch: properly refcount vport-vxlan module

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 25 Nov 2015 18:05:27 +0100

> After 614732eaa12d, no refcount is mainteined for the vport-vxlan module.
> This allows the userspace to remove such module while vport-vxlan
> devices still exist, which lead to later oops, i.e. when
> the openvswitch module is removed.
> 
> Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

This is so error prone, with some vport_ops needing to mark the
module and some don't (because they are in the main openvswitch
driver).

Fix this properly, by making the vport_ops register function be
a macro that sets THIS_MODULE in the vport_ops before passing it
on down to the real registry function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html