netdev - Re: [PATCH net v2] openvswitch: properly refcount vport-vxlan module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1448984508.3380707.454779977.1FF45EA1@webmail.messagingengine.com>
Date:	Tue, 01 Dec 2015 16:41:48 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Paolo Abeni <pabeni@...hat.com>
Cc:	netdev@...r.kernel.org, Pravin Shelar <pshelar@...ira.com>,
	Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net v2] openvswitch: properly refcount vport-vxlan module

On Tue, Dec 1, 2015, at 14:19, Paolo Abeni wrote:
> Currently all the vport_ops list manipulation functions are protected by
> the ovs_lock (even the lookup): the scenario described above should not
> be possible.

This makes all sense and it seems no use-after-free is possible at all
(I didn't notice the lookup path takes the lock). But the macro still
looks ugly and modifies a global struct with a per-module linked symbol.
David, why exactly didn't you like the first patch? Seems to me it does
what is actually needed.

Thanks,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html