netdev - Re: [RFC 4/4] i40e: handle per queue rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151201114726.43d0540c@xeon-e3>
Date:	Tue, 1 Dec 2015 11:47:26 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	kan.liang@...el.com
Cc:	netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
	davem@...emloft.net, jesse.brandeburg@...el.com,
	andi@...stfloor.org, jeffrey.t.kirsher@...el.com,
	shannon.nelson@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, matthew.vick@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	john.r.fastabend@...el.com, ogerlitz@...lanox.com,
	edumazet@...gle.com, jiri@...lanox.com, sfeldma@...il.com,
	gospo@...ulusnetworks.com, sasha.levin@...cle.com,
	f.fainelli@...il.com, dsahern@...il.com, tj@...nel.org,
	cascardo@...hat.com, corbet@....net
Subject: Re: [RFC 4/4] i40e: handle per queue rx_usecs setting

On Tue,  1 Dec 2015 08:01:32 +0000
kan.liang@...el.com wrote:

> +u32 i40e_ndo_get_per_queue_rx_usecs(struct net_device *dev, int index)
> +{
> +	struct i40e_netdev_priv *np = netdev_priv(dev);
> +	struct i40e_vsi *vsi = np->vsi;
> +	struct i40e_pf *pf = vsi->back;
> +	struct i40e_hw *hw = &pf->hw;
> +	u32 val;
> +
> +	val = rd32(hw, I40E_PFINT_ITRN(0, index));
> +
> +	return (val * 2);

Please don't put useless paren's around return value.
That is a BSD style that is not practiced in Linux.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html