netdev - Re: [PATCH] drivers: net: xgene: fix Tx flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151201.152127.1326770277234261993.davem@davemloft.net>
Date:	Tue, 01 Dec 2015 15:21:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	isubramanian@....com
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	patches@....com, kdinh@....com
Subject: Re: [PATCH] drivers: net: xgene: fix Tx flow control

From: Iyappan Subramanian <isubramanian@....com>
Date: Fri, 27 Nov 2015 19:22:31 -0800

> Currently the Tx flow control is based on reading the hardware state,
> which is not accurate since it may not reflect the descriptors that
> are not yet reached the memory.
> 
> To accurately control the Tx flow, changing it to be software based.
> 
> Signed-off-by: Iyappan Subramanian <isubramanian@....com>
> Tested-by: Khuong Dinh <kdinh@....com>

Having a new atomic operation for every completion descriptor
operation is very excessive.

Especially when there is probably some other lock being held in all
of these paths upon which you can use for synchornization.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html