netdev - Re: [PATCH net-next 3/3] vxlan: support ndo_fill_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Dec 2015 02:57:47 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	Jesse Gross <jesse@...ira.com>,
	Pravin B Shelar <pshelar@...ira.com>
Subject: Re: [PATCH net-next 3/3] vxlan: support ndo_fill_metadata_dst also
 for IPv6

Hi Jiri,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jiri-Benc/vxlan-IPv6-fill_metadata_dst-support/20151203-021449
config: x86_64-randconfig-i0-201548 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/net/vxlan.c: In function 'vxlan_fill_metadata_dst':
>> drivers/net/vxlan.c:2408:20: warning: unused variable 'ndst' [-Wunused-variable]
     struct dst_entry *ndst;
                       ^

vim +/ndst +2408 drivers/net/vxlan.c

  2392		if (dst->remote_ip.sa.sa_family == AF_INET6)
  2393			max_mtu = lowerdev->mtu - VXLAN6_HEADROOM;
  2394		else
  2395			max_mtu = lowerdev->mtu - VXLAN_HEADROOM;
  2396	
  2397		if (new_mtu < 68 || new_mtu > max_mtu)
  2398			return -EINVAL;
  2399	
  2400		dev->mtu = new_mtu;
  2401		return 0;
  2402	}
  2403	
  2404	static int vxlan_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
  2405	{
  2406		struct vxlan_dev *vxlan = netdev_priv(dev);
  2407		struct ip_tunnel_info *info = skb_tunnel_info(skb);
> 2408		struct dst_entry *ndst;
  2409		struct rtable *rt;
  2410		__be16 sport, dport;
  2411	
  2412		sport = udp_flow_src_port(dev_net(dev), skb, vxlan->cfg.port_min,
  2413					  vxlan->cfg.port_max, true);
  2414		dport = info->key.tp_dst ? : vxlan->cfg.dst_port;
  2415	
  2416		if (ip_tunnel_info_af(info) == AF_INET) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (27362 bytes)