[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20151202.154800.1567031979226825020.davem@davemloft.net>
Date: Wed, 02 Dec 2015 15:48:00 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: joe@...ches.com
Cc: jeffrey.t.kirsher@...el.com, intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org, sergei.shtylyov@...entembedded.com,
shannon.nelson@...el.com
Subject: Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output
From: Joe Perches <joe@...ches.com>
Date: Wed, 02 Dec 2015 02:12:29 -0800
> On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote:
>> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote:
>> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string
>> > building")
>> > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in
>> > function i40e_print_features.
>> >
>> > Fix it.
>> >
>> > Miscellanea:
>> >
>> > o Remove unnecessary string variable
>> > o Add space before not after fixed strings
>> > o Use kmalloc not kzalloc
>> > o Don't initialize i to 0, use result of first snprintf
>> >
>> > Noticed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>
>> Don't you mean Reported-by? I am not aware of Noticed-by as being a
>> recognized signature.
>
> At least for the get_maintainer script, "<anything>-by:" is a signature
Is patchwork using the same regexp? If not, for the time being don't
user non-standard tags, and furthermore please ask the patchwork folks
to use something similar to getmaintainer.pl
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists