netdev - Re: [patch net-next 09/26] team: fill-up LAG changeupper info struct and pass it along

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMj_AwtbRW7=FKFSMR9ed8B2Yak7U5zTSVHtf-r5+2ytRA@mail.gmail.com>
Date:	Wed, 2 Dec 2015 07:36:16 +0200
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Ido Schimmel <idosch@...lanox.com>,
	Elad Raz <eladr@...lanox.com>, yotamg@...lanox.com,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [patch net-next 09/26] team: fill-up LAG changeupper info struct
 and pass it along

On Tue, Dec 1, 2015 at 3:48 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> Initialize netdev_lag_upper_info structure by TX type according to
> current team mode and pass it along via netdev_master_upper_dev_link.
[...]
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -1078,23 +1078,24 @@ static void team_port_disable_netpoll(struct team_port *port)
>  }
>  #endif
>
> -static int team_upper_dev_link(struct net_device *dev,
> -                              struct net_device *port_dev)
> +static int team_upper_dev_link(struct team *team, struct team_port *port)
>  {
> +       struct netdev_lag_upper_info lag_upper_info;
>         int err;
>
> -       err = netdev_master_upper_dev_link(port_dev, dev, NULL, NULL);
> +       lag_upper_info.tx_type = team->mode->lag_tx_type;
> +       err = netdev_master_upper_dev_link(port->dev, team->dev, NULL,
> +                                          &lag_upper_info);
>         if (err)
>                 return err;
> -       port_dev->priv_flags |= IFF_TEAM_PORT;
> +       port->dev->priv_flags |= IFF_TEAM_PORT;
>         return 0;
>  }

you also added into this patch moving

from struct netdevice *dev_port->xxx

to struct team_port *port->dev->xxx

which goes beyond the logical change / functionality this  patch
introduces... maybe
better put it in a separate patch?

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html