netdev - Re: [PATCH] sctp: use GFP_USER for user-controlled kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151202.234008.2105465549392712497.davem@davemloft.net>
Date:	Wed, 02 Dec 2015 23:40:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	vyasevich@...il.com, nhorman@...driver.com, daniel@...earbox.net,
	linux-kernel@...r.kernel.org, syzkaller@...glegroups.com,
	dvyukov@...gle.com, kcc@...gle.com, glider@...gle.com,
	sasha.levin@...cle.com, edumazet@...gle.com
Subject: Re: [PATCH] sctp: use GFP_USER for user-controlled kmalloc

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Mon, 30 Nov 2015 14:32:54 -0200

> Dmitry Vyukov reported that the user could trigger a kernel warning by
> using a large len value for getsockopt SCTP_GET_LOCAL_ADDRS, as that
> value directly affects the value used as a kmalloc() parameter.
> 
> This patch thus switches the allocation flags from all user-controllable
> kmalloc size to GFP_USER to put some more restrictions on it and also
> disables the warn, as they are not necessary.
> 
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Acked-by: Daniel Borkmann <daniel@...earbox.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html