netdev - Re: [patch net-next v3 04/28] net: add netif_is_team

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1449146761.6379.20.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 03 Dec 2015 04:46:01 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, yotamg@...lanox.com, ogerlitz@...lanox.com,
	j.vosburgh@...il.com, vfalico@...il.com, gospo@...ulusnetworks.com,
	dsa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
	pjonnala@...adcom.com, f.fainelli@...il.com, sfeldma@...il.com,
	john.fastabend@...il.com, roopa@...ulusnetworks.com, andrew@...n.ch
Subject: Re: [patch net-next v3 04/28] net: add netif_is_team_master helper

On Thu, 2015-12-03 at 12:12 +0100, Jiri Pirko wrote:

>   *	struct net_device - The DEVICE structure.
> @@ -3887,6 +3890,11 @@ static inline bool netif_is_ovs_master(const struct net_device *dev)
>  	return dev->priv_flags & IFF_OPENVSWITCH;
>  }
>  
> +static inline bool netif_is_team_master(struct net_device *dev)
> +{
> +	return dev->priv_flags & IFF_TEAM;
> +}
> +

Please add 'const' qualifiers whenever possible, like for
netif_is_ovs_master(const struct net_device *dev)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html