netdev - Re: [PATCH v2 net-next] tcp: suppress too verbose messages in tcp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151202.234454.571565058483226185.davem@davemloft.net>
Date:	Wed, 02 Dec 2015 23:44:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] tcp: suppress too verbose messages in
 tcp_send_ack()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 30 Nov 2015 08:57:28 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> If tcp_send_ack() can not allocate skb, we properly handle this
> and setup a timer to try later.
> 
> Use __GFP_NOWARN to avoid polluting syslog in the case host is
> under memory pressure, so that pertinent messages are not lost under
> a flood of useless information.
> 
> sk_gfp_atomic() can use its gfp_mask argument (all callers currently
> were using GFP_ATOMIC before this patch)
> 
> We rename sk_gfp_atomic() to sk_gfp_mask() to clearly express this
> function now takes into account its second argument (gfp_mask)
> 
> Note that when tcp_transmit_skb() is called with clone_it set to false,
> we do not attempt memory allocations, so can pass a 0 gfp_mask, which
> most compilers can emit faster than a non zero or constant value.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> v2: rename sk_gfp_atomic() to sk_gfp_mask()

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html