netdev - Re: [net-next 07/15] i40e: propagate properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMjX0_TULVQX9XoFvwfH=Lh9_jjc1m_oeu1GXdJBh-QbDQ@mail.gmail.com>
Date:	Thu, 3 Dec 2015 16:00:28 +0200
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Mitch Williams <mitch.a.williams@...el.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>
Subject: Re: [net-next 07/15] i40e: propagate properly

On Thu, Dec 3, 2015 at 3:25 PM, Jeff Kirsher
<jeffrey.t.kirsher@...el.com> wrote:
> From: Mitch Williams <mitch.a.williams@...el.com>

Hi Mitch,

Can you use a more descriptive title for the patch, propagate what properly?


> i40e_sync_vsi_filters() is the surly teenager of this driver. It says
> it's going to report errors, but it doesn't actually do that most of the
> time. And when it does, it leaves a mess.
>
> Change this function to have a common exit point so it will properly
> release the busy lock on the VSI. Propagate errors to the callers.
> Finally, adjust a few callers to check for and deal with errors from
> this function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html