netdev - Re: [PATCH v2 net] ipv6: kill sk_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151203.113243.972969856777923620.davem@davemloft.net>
Date:	Thu, 03 Dec 2015 11:32:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	dvyukov@...gle.com, vyasevich@...il.com, yoshfuji@...ux-ipv6.org,
	netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH v2 net] ipv6: kill sk_dst_lock

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 02 Dec 2015 21:53:57 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While testing the np->opt RCU conversion, I found that UDP/IPv6 was
> using a mixture of xchg() and sk_dst_lock to protect concurrent changes
> to sk->sk_dst_cache, leading to possible corruptions and crashes.
> 
> ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest
> way to fix the mess is to remove sk_dst_lock completely, as we did for
> IPv4.
> 
> __ip6_dst_store() and ip6_dst_store() share same implementation.
> 
> sk_setup_caps() being called with socket lock being held or not,
> we have to use sk_dst_set() instead of __sk_dst_set()
> 
> Note that I had to move the "np->dst_cookie = rt6_get_cookie(rt);"
> in ip6_dst_store() before the sk_setup_caps(sk, dst) call.
> 
> This is because ip6_dst_store() can be called from process context,
> without any lock held.
> 
> As soon as the dst is installed in sk->sk_dst_cache, dst can be freed
> from another cpu doing a concurrent ip6_dst_store()
> 
> Doing the dst dereference before doing the install is needed to make
> sure no use after free would trigger.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> ---
> v2: added the explanation about rt6_get_cookie(rt) called
> before sk_setup_caps()

Applied to 'net', with some fuzz... did you happen to generate this
against net-next by chance?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html