netdev - Re: [net-next v2] i40e: Fix i40e_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151203.114946.1155215569226167223.davem@davemloft.net>
Date:	Thu, 03 Dec 2015 11:49:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	intel-wired-lan@...ts.osuosl.org, joe@...ches.com,
	netdev@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	shannon.nelson@...el.com
Subject: Re: [net-next v2] i40e: Fix i40e_print_features() VEB mode output

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu,  3 Dec 2015 04:20:57 -0800

> From: Joe Perches <joe@...ches.com>
> 
> Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string building")
> added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in
> function i40e_print_features.
> 
> Fix it.
> 
> Miscellanea:
> 
> - Remove unnecessary string variable
> - Add space before not after fixed strings
> - Use kmalloc not kzalloc
> - Don't initialize i to 0, use result of first snprintf
> 
> Reported-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> v2: fixed patch conflicts when trying to apply to my next-queue tree
>     (dev-queue branch), also fixed "Noticed-by" to the more acceptable
>     "Reported-by"

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html