netdev - RE: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

Open Source and information security mailing list archives

Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0F96CBB6@ORSMSX104.amr.corp.intel.com>
Date:	Thu, 3 Dec 2015 16:53:04 +0000
From:	"Bowers, AndrewX" <andrewx.bowers@...el.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>,
	David Miller <davem@...emloft.net>
CC:	Sowmini Varadhan <sowmini.varadhan@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	netdev <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open
	Firmware or IDPROM

I get an error -11 on driver init with this patch applied, I can revert it and everything works normally. Dmesg screenshot is attached, can supply complete dmesg log if needed.
--Andrew


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...ts.osuosl.org] On
> Behalf Of Andy Shevchenko
> Sent: Thursday, November 05, 2015 11:33 AM
> To: David Miller <davem@...emloft.net>
> Cc: Sowmini Varadhan <sowmini.varadhan@...cle.com>; linux-
> kernel@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; netdev
> <netdev@...r.kernel.org>
> Subject: Re: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open
> Firmware or IDPROM
> 
> On Thu, Nov 5, 2015 at 8:31 PM, David Miller <davem@...emloft.net>
> wrote:
> > From: Andy Shevchenko <andy.shevchenko@...il.com>
> > Date: Thu, 5 Nov 2015 20:13:21 +0200
> >
> >> What about
> >>
> >> if (!addr)
> >>  return -ENODATA;
> >
> > I totally disagree.  of_get_phy_mode() and other similar attribute
> > probing mechanisms use -ENODEV.
> 
> Okay, then just
> if (!addr)
>  return -ENODEV;
> 
> --
> With Best Regards,
> Andy Shevchenko
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...ts.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Download attachment "dmesgerror.jpg" of type "image/jpeg" (170030 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives