netdev - Re: [PATCH v2 net] ipv4: igmp: Allow removing groups from a removed interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151203.120736.596557724540684861.davem@davemloft.net>
Date:	Thu, 03 Dec 2015 12:07:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] ipv4: igmp: Allow removing groups from a
 removed interface

From: Andrew Lunn <andrew@...n.ch>
Date: Tue,  1 Dec 2015 16:31:08 +0100

> When a multicast group is joined on a socket, a struct ip_mc_socklist
> is appended to the sockets mc_list containing information about the
> joined group.
> 
> If the interface is hot unplugged, this entry becomes stale. Prior to
> commit 52ad353a5344f ("igmp: fix the problem when mc leave group") it
> was possible to remove the stale entry by performing a
> IP_DROP_MEMBERSHIP, passing either the old ifindex or ip address on
> the interface. However, this fix enforces that the interface must
> still exist. Thus with time, the number of stale entries grows, until
> sysctl_igmp_max_memberships is reached and then it is not possible to
> join and more groups.
> 
> The previous patch fixes an issue where a IP_DROP_MEMBERSHIP is
> performed without specifying the interface, either by ifindex or ip
> address. However here we do supply one of these. So loosen the
> restriction on device existence to only apply when the interface has
> not been specified. This then restores the ability to clean up the
> stale entries.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 52ad353a5344f "(igmp: fix the problem when mc leave group")

Applied and queued up for -stable, thanks Andrew.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html