netdev - Re: [PATCH] net: lpc_eth: remove irq > NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151203.150252.916768886355672458.davem@davemloft.net>
Date:	Thu, 03 Dec 2015 15:02:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vz@...ia.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: lpc_eth: remove irq > NR_IRQS check from probe()

From: Vladimir Zapolskiy <vz@...ia.com>
Date: Wed,  2 Dec 2015 08:12:13 +0200

> If the driver is used on an ARM platform with SPARSE_IRQ defined,
> semantics of NR_IRQS is different (minimal value of virtual irqs) and
> by default it is set to 16, see arch/arm/include/asm/irq.h.
> 
> This value may be less than the actual number of virtual irqs, which
> may break the driver initialization. The check removal allows to use
> the driver on such a platform, and, if irq controller driver works
> correctly, the check is not needed on legacy platforms.
> 
> Fixes a runtime problem:
> 
>     lpc-eth 31060000.ethernet: error getting resources.
>     lpc_eth: lpc-eth: not found (-6).
> 
> Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html