netdev - Re: Asterisk deadlocks since Kernel 4.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4C2AFE05-10C2-412C-B065-B57CFCBEDD9A@profihost.ag>
Date:	Thu, 3 Dec 2015 09:23:34 +0100
From:	Stefan Priebe - Profihost AG <s.priebe@...fihost.ag>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	Florian Weimer <fweimer@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, netdev@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	herbert@...dor.apana.org.au
Subject: Re: Asterisk deadlocks since Kernel 4.1

> Am 02.12.2015 um 12:40 schrieb Hannes Frederic Sowa <hannes@...essinduktion.org>:
> 
> Hello Stefan,
> 
> Stefan Priebe - Profihost AG <s.priebe@...fihost.ag> writes:
> 
> 
>> here are the results.
>> 
>> It works with 4.1.
>> It works with 4.2.
>> It does not work with 4.1.13.
>> 
>> git bisect tells me it stopped working after those two commits were applied:
>> 
>> commit d48623677191e0f035d7afd344f92cf880b01f8e
>> Author: Herbert Xu <herbert@...dor.apana.org.au>
>> Date:   Tue Sep 22 11:38:56 2015 +0800
>> 
>>    netlink: Replace rhash_portid with bound
>> 
>> commit 4e27762417669cb459971635be550eb7b5598286
>> Author: Herbert Xu <herbert@...dor.apana.org.au>
>> Date:   Fri Sep 18 19:16:50 2015 +0800
>> 
>>    netlink: Fix autobind race condition that leads to zero port ID
> 
> Cool, thanks a lot. Does this patch make a difference?
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 59651af..278e94c 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1137,7 +1137,7 @@ static int netlink_insert(struct sock *sk, u32 portid)
> 
>    /* We need to ensure that the socket is hashed and visible. */
>    smp_wmb();
> -    nlk_sk(sk)->bound = portid;
> +    nlk_sk(sk)->bound = true;
> 
> err:
>    release_sock(sk);

Will try that soon but already started another test. I reverted all netlink patches from 4.1.13 back to 4.1 and applied all netlink patches from 4.1 up to 4.3.

Greets,
Stefan--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html