netdev - Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Dec 2015 19:01:40 +0900
From:	Yoshihiro Kaneko <ykaneko0929@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH net-next] ravb: ptp: Add CONFIG mode support

Hello Sergei,

Thanks for your review.

2015-12-04 6:09 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
> Hello.
>
> On 12/01/2015 08:04 PM, Yoshihiro Kaneko wrote:
>
>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>>
>> This patch makes PTP support active in CONFIG mode on R-Car Gen3.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@...il.com>
>> ---
>>
>> This patch is based on the master branch of David Miller's next networking
>> tree.
>>
>>   drivers/net/ethernet/renesas/ravb.h      |  1 +
>>   drivers/net/ethernet/renesas/ravb_main.c | 33
>> +++++++++++++++++++++++++++-----
>>   2 files changed, 29 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb.h
>> b/drivers/net/ethernet/renesas/ravb.h
>> index f9dee74..9fbe92a 100644
>> --- a/drivers/net/ethernet/renesas/ravb.h
>> +++ b/drivers/net/ethernet/renesas/ravb.h
>> @@ -206,6 +206,7 @@ enum CCC_BIT {
>>         CCC_OPC_RESET   = 0x00000000,
>>         CCC_OPC_CONFIG  = 0x00000001,
>>         CCC_OPC_OPERATION = 0x00000002,
>> +       CCC_GAC         = 0x00000080,
>
>
>    I'd have added a comment that it's gen3 specific.
>
> [...]
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>> b/drivers/net/ethernet/renesas/ravb_main.c
>> index 990dc55..293046d 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>
> [...]
>>
>> @@ -1814,6 +1825,10 @@ static int ravb_probe(struct platform_device *pdev)
>>         /* Initialise HW timestamp list */
>>         INIT_LIST_HEAD(&priv->ts_skb_list);
>>
>> +       /* Initialise PTP Clock driver */
>> +       if (chip_id != RCAR_GEN2)
>> +               ravb_ptp_init(ndev, pdev);
>> +
>>         /* Debug message level */
>>         priv->msg_enable = RAVB_DEF_MSG_ENABLE;
>>
>> @@ -1855,6 +1870,10 @@ out_napi_del:
>>   out_dma_free:
>>         dma_free_coherent(ndev->dev.parent, priv->desc_bat_size,
>> priv->desc_bat,
>>                           priv->desc_bat_dma);
>> +
>> +       /* Stop PTP Clock driver */
>> +       if (chip_id != RCAR_GEN2)
>> +               ravb_ptp_stop(ndev);
>
>
>    This is clearly misplaced.

It's my fault.

>
> [...]
>
> MBR, Sergei
>

Regards,
Kaneko
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html