netdev - Re: [PATCH RESEND v7] i40e: Look up MAC address in Open Firmware or IDPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151205203825.GA8283@oracle.com>
Date:	Sat, 5 Dec 2015 15:38:25 -0500
From:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
To:	Shannon Nelson <shannon.nelson@...el.com>
Cc:	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	matthew.vick@...el.com, john.ronciak@...el.com,
	mitch.a.williams@...el.com, andy.shevchenko@...il.com
Subject: Re: [PATCH RESEND v7] i40e: Look up MAC address in Open Firmware or
 IDPROM

On (12/04/15 17:40), Shannon Nelson wrote:
> 
> I'd write this just a little differently to match the rest of the driver:
> 
>       ret = i40e_aq_add_macvlan(&vsi->back->hw, vsi->seid, &element, 1, NULL);
>       if (!ret) {

You mean if (ret), right? (i.e., ret == 0 is success)

>               dev_info(&vsi->back->pdev->dev,
>                        "add filter failed err %s aq_err %s\n",

BTW, there are some other places in that file where the return
status form i40e_aq_add_macvlan() is ignored, which makes this a bit
confusing ..
  :
  :

> > +{
> > +       struct device_node *dp = pci_device_to_OF_node(pdev);
> 
> This gives me a compile warning, probably because I don't have
> CONFIG_OF enabled.

Odd, what sort of compile warning? I dont see that on my x86 
machine (and I dont have CONFIG_OF either), and kbuild-test-robot
did not catch that either, afaict. Perhaps you are missing some 
include files?

Without the dp definition, of_get_mac_address() further below
will not find a "dp".

Rest of the comments are addressed in v8 that I just sent out.

--Sowmini



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html