netdev - Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 Dec 2015 23:15:07 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	yankejian <yankejian@...wei.com>, davem@...emloft.net,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	xuwei5@...ilicon.com, catalin.marinas@....com, will.deacon@....com,
	wangkefeng.wang@...wei.com, dingtianhong@...wei.com,
	liguozhu@...wei.com, Yisen.Zhuang@...wei.com, sboyd@...eaurora.org,
	haojian.zhuang@...aro.org, wangzhou1@...ilicon.com,
	bintian.wang@...wei.com, long.wanglong@...wei.com,
	leo.yan@...aro.org, devicetree@...r.kernel.org,
	haifeng.wei@...wei.com, netdev@...r.kernel.org,
	linuxarm@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio

On Saturday 05 December 2015 15:56:57 yankejian wrote:
>                 #size-cells = <0>;
>                 compatible = "hisilicon,hns-mdio";
> -               reg = <0x0 0x803c0000 0x0 0x10000
> -                      0x0 0x80000000 0x0 0x10000>;
> +               reg = <0x0 0x803c0000 0x0 0x10000>;
> +               subctrl_vbase = <&peri_c_subctrl>;
>  
>                 soc0_phy0: ethernet-phy@0 {
>                         reg = <0x0>;

I don't see the subctrl_vbase property documented in the binding. Please
modify the binding as well.

Also, please use the normal naming conventions using '-' instead of '_'
inside of property names.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html