netdev - Re: [PATCH net-next] sfc: check warm_boot_count after other functions have been reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151205.175931.170629319560007846.davem@davemloft.net>
Date:	Sat, 05 Dec 2015 17:59:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bkenward@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	dpieczko@...arflare.com
Subject: Re: [PATCH net-next] sfc: check warm_boot_count after other
 functions have been reset

From: Bert Kenward <bkenward@...arflare.com>
Date: Fri, 4 Dec 2015 08:48:39 +0000

> From: Daniel Pieczko <dpieczko@...arflare.com>
> 
> A change in MCFW behaviour means that the net driver must update its record
> of the warm_boot_count by reading it from the ER_DZ_BIU_MC_SFT_STATUS
> register.
> 
> On v4.6.x MCFW the global boot count was incremented when some functions
> needed to be reset to enable multicast chaining, so all functions saw the
> same value.  In that case, the driver needed to increment its
> warm_boot_count when other functions were reset, to avoid noticing it later
> and then trying to reset itself to recover unnecessarily.
> 
> With v4.7+ MCFW, the boot count in firmware doesn't change as that is
> unnecessary since the PFs that have been reset will each receive an MC
> reboot notification.  In that case, the driver re-reads the unchanged
> value.
> 
> Signed-off-by: Bert Kenward <bkenward@...arflare.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html