netdev - Re: [PATCH net] mpls: fix sending of local encapped packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151207.163327.128104390576260749.davem@davemloft.net>
Date:	Mon, 07 Dec 2015 16:33:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rshearma@...cade.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	ebiederm@...ssion.com, sam.h.russell@...il.com
Subject: Re: [PATCH net] mpls: fix sending of local encapped packets

From: Robert Shearman <rshearma@...cade.com>
Date: Mon, 7 Dec 2015 12:53:15 +0000

> Locally generated IPv4 and (probably) IPv6 packets are dropped because
> skb->protocol isn't set. We could write wrappers to lwtunnel_output
> for IPv4 and IPv6 that set the protocol accordingly and then call
> lwtunnel_output, but mpls_output relies on the AF-specific type of dst
> anyway to get the via address.
> 
> Therefore, make use of dst->dst_ops->family in mpls_output to
> determine the type of nexthop and thus protocol of the packet instead
> of checking skb->protocol.
> 
> Fixes: 61adedf3e3f1 ("route: move lwtunnel state to dst_entry")
> Reported-by: Sam Russell <sam.h.russell@...il.com>
> Signed-off-by: Robert Shearman <rshearma@...cade.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html