netdev - Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56654A36.6090106@huawei.com>
Date:	Mon, 7 Dec 2015 16:58:30 +0800
From:	"Yankejian (Hackim Yim)" <yankejian@...wei.com>
To:	Joe Perches <joe@...ches.com>, David Miller <davem@...emloft.net>
CC:	<lisheng011@...wei.com>, <lipeng321@...wei.com>,
	<salil.mehta@...wei.com>, <huangdaode@...ilicon.com>,
	<xuwei5@...ilicon.com>, <liguozhu@...wei.com>,
	<haifeng.wei@...wei.com>, <yisen.zhuang@...wei.com>,
	<linuxarm@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: hns: optimize XGE capability by reducing
 cpu usage


On 2015/12/7 11:32, Joe Perches wrote:
> On Sun, 2015-12-06 at 22:29 -0500, David Miller wrote:
>> > From: yankejian <yankejian@...wei.com>
>> > Date: Sat, 5 Dec 2015 15:32:29 +0800
>> > 
>>> > > +#if (PAGE_SIZE < 8192)
>>> > > +     if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) {
>>> > > +             truesize = hnae_buf_size(ring);
>>> > > +     } else {
>>> > > +             truesize = ALIGN(size, L1_CACHE_BYTES);
>>> > > +             last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
>>> > > +     }
>>> > > +
>>> > > +#else
>>> > > +             truesize = ALIGN(size, L1_CACHE_BYTES);
>>> > > +             last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
>>> > > +#endif
>> > 
>> > This is not indented properly, and it looks terrible.
> And it makes one curious as to why last_offset isn't set
> in the first block.

Hi Joe,
if hnae_buf_size que equal to HNS_BUFFER_SIZE, last_offset is useless in the routines of this function.
so it is ignored in the first block. thanks for your suggestion.

Best regards,
yankejian


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html