netdev - Re: [PATCH net v2 2/2] vxlan: support ndo_fill_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151207111955.48821381@griffin>
Date:	Mon, 7 Dec 2015 11:19:55 +0100
From:	Jiri Benc <jbenc@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	pshelar@...ira.com, netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also
 for IPv6

On Fri, 04 Dec 2015 14:28:38 -0500 (EST), David Miller wrote:
> From: Pravin Shelar <pshelar@...ira.com>
> > Rather than checking IS_ENABLED(CONFIG_IPV6) three separate times, all
> > code can is restructured in one #if #else block by moving the ndst
> > definition to IPv6 local block.
> 
> Agreed, you should be putting variable definitions into the deepest most
> containing scope anyways.  So if you declare 'ndst' inside of the else
> branch you'll be doing that plus decreasing the amount of CPP tests in
> this file.

No problem. I actually had it that way but decided that I didn't like
the #if #else maze. I'll change it and send v3.

 Jiri

-- 
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html