netdev - Re: [PATCH] vhost: vsock: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151208.121356.1131159668858222040.davem@davemloft.net>
Date:	Tue, 08 Dec 2015 12:13:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	arnd@...db.de, netdev@...r.kernel.org, kvm@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, asias@...hat.com, stefanha@...hat.com
Subject: Re: [PATCH] vhost: vsock: select CONFIG_VHOST

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Tue, 8 Dec 2015 18:09:44 +0200

> On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote:
>> When building the new vsock code without vhost, we get a build error:
>> 
>> drivers/built-in.o: In function `vhost_vsock_flush':
>> :(.text+0x24d29c): undefined reference to `vhost_poll_flush'
>> 
>> This adds an explicit 'select' like we have for the other vhost
>> drivers.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> This will need to be done eventually, so
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> 
> but I really think the right thing for now is to revert current vsock
> code, or disable building it unconditionally.  Stefan, could you please
> send a patch like this?

I'm waiting for the full single revert patch and will apply it as
soon as I receive it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html