netdev - Re: [RFC 1/1] ethtool: support per queue coalesce options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-MU4PrJ7xrEmR5k_1qNeXFzybsJMo-SAPX-Us++YokX+zeGQ@mail.gmail.com>
Date:	Tue, 8 Dec 2015 10:17:51 -0800
From:	Shannon Nelson <shannon.nelson@...el.com>
To:	kan.liang@...el.com
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	bwh@...nel.org, Jesse Brandeburg <jesse.brandeburg@...el.com>,
	andi@...stfloor.org, f.fainelli@...il.com,
	alexander.duyck@...il.com,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	mitch.a.williams@...el.com, ogerlitz@...lanox.com,
	edumazet@...gle.com, jiri@...lanox.com, sfeldma@...il.com,
	gospo@...ulusnetworks.com, sasha.levin@...cle.com,
	dsahern@...il.com, tj@...nel.org, cascardo@...hat.com,
	corbet@....net
Subject: Re: [RFC 1/1] ethtool: support per queue coalesce options

On Mon, Dec 7, 2015 at 8:44 PM,  <kan.liang@...el.com> wrote:
> From: Kan Liang <kan.liang@...el.com>
>
> Intruduce new coalesce option "queue" to get/set coalesce value to

s/Intruduce/Introduce/

[...]

> diff --git a/ethtool.c b/ethtool.c
> index 92c40b8..7c644db 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -1178,6 +1178,12 @@ static int dump_channels(const struct ethtool_channels *echannels)
>
>  static int dump_coalesce(const struct ethtool_coalesce *ecoal)
>  {
> +       if (ecoal->queue < 0)
> +               fprintf(stdout, "Queue: All\n");

If some queues have been given different settings, then "All" is
rather misleading, and there seems to be no way to indicate that some
queues have separate settings.

sln
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html