netdev - Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S36dU-RLUSTTZz8dVZHD7=p3=modbjUOePKMYG96FrA_zA@mail.gmail.com>
Date:	Tue, 8 Dec 2015 11:59:45 -0800
From:	Tom Herbert <tom@...bertland.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jesse Gross <jesse@...ira.com>,
	Kernel Team <kernel-team@...com>
Subject: Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville
<linville@...driver.com> wrote:
> On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote:
>> Add support for remote checksum offload in both the normal and GRO
>> paths. netlink command are used to enable sending of the Remote
>> Checksum Data, and allow processing of it on receive. The Remote
>
Extraneous.

> afsO&^(*&5^a+++NO CARRIER
>
> Did you mean to finish that sentence? ;-)
>
>> Signed-off-by: Tom Herbert <tom@...bertland.com>
>
> Jesse is going to have to comment on your (ab)use of the reserved
> fields.  I presume that an RFC would be forthcoming?
>
I'll spin an I-D once there is agreement on the approach. This is
identical to VXLAN excepted the bit flag indicating csum_start is
present might be different.

https://tools.ietf.org/html/draft-herbert-vxlan-rco-00


>> diff --git a/include/net/geneve.h b/include/net/geneve.h
>> index 3106ed6..b59ad0a 100644
>> --- a/include/net/geneve.h
>> +++ b/include/net/geneve.h
>> @@ -8,9 +8,9 @@
>>
>>  /* Geneve Header:
>>   *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>> - *  |Ver|  Opt Len  |O|C|    Rsvd.  |          Protocol Type        |
>> + *  |Ver|  Opt Len  |O|C|X|  Rsvd.  |          Protocol Type        |
>>   *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>> - *  |        Virtual Network Identifier (VNI)       |    Reserved   |
>> + *  |        Virtual Network Identifier (VNI)       |U| Csum start  |
>>   *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>   *  |                    Variable Length Options                    |
>>   *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> Otherwise, LGTM -- I'm really happy to see Geneve get this attention!
>
> Acked-by: John W. Linville <linville@...driver.com>
>
> --
> John W. Linville                Someday the world will need a hero, and you
> linville@...driver.com                  might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html