netdev - Re: [PATCH 1/2] blkcipher: Copy iv from desc even for 0-len walks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151209121858.GC27962@gondor.apana.org.au>
Date:	Wed, 9 Dec 2015 20:18:58 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Jason A. Donenfeld" <Jason@...c4.com>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Netdev <netdev@...r.kernel.org>,
	martin@...ongswan.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] blkcipher: Copy iv from desc even for 0-len walks

On Sun, Dec 06, 2015 at 02:51:37AM +0100, Jason A. Donenfeld wrote:
> Some ciphers actually support encrypting zero length plaintexts. For
> example, many AEAD modes support this. The resulting ciphertext for
> those winds up being only the authentication tag, which is a result of
> the key, the iv, the additional data, and the fact that the plaintext
> had zero length. The blkcipher constructors won't copy the IV to the
> right place, however, when using a zero length input, resulting in
> some significant problems when ciphers call their initialization
> routines, only to find that the ->iv parameter is uninitialized. One
> such example of this would be using chacha20poly1305 with a zero length
> input, which then calls chacha20, which calls the key setup routine,
> which eventually OOPSes due to the uninitialized ->iv member.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> Cc: <stable@...r.kernel.org>

Applied to crypto.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html