netdev - Re: [PATCH net-next] Doc: Micrel-ksz90x1.txt: Document deprecated MAC OF properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C503A8D0-5FBB-4324-8C9D-3469C897999E@gmail.com>
Date:	Wed, 09 Dec 2015 13:46:08 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] Doc: Micrel-ksz90x1.txt: Document deprecated MAC OF properties

On December 9, 2015 10:39:03 AM PST, Andrew Lunn <andrew@...n.ch> wrote:
>Phy properties are expected to be found in the PHY OF node. However
>this Micrel driver also allows them to be placed into the MAC OF node.
>This is deprecated. Document it as such, and remove the example using
>the deprecated method to prevent people copying it into new device
>tree files.
>
>Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

>---
>.../devicetree/bindings/net/micrel-ksz90x1.txt          | 17
>++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
>b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
>index 692076fda0e5..f9c32adab5c6 100644
>--- a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
>+++ b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
>@@ -1,8 +1,9 @@
> Micrel KSZ9021/KSZ9031 Gigabit Ethernet PHY
> 
>-Some boards require special tuning values, particularly when it comes
>to
>-clock delays. You can specify clock delay values by adding
>-micrel-specific properties to an Ethernet OF device node.
>+Some boards require special tuning values, particularly when it comes
>+to clock delays. You can specify clock delay values in the PHY OF
>+device node. Deprecated, but still supported, these properties can
>+also be added to an Ethernet OF device node.
> 
> Note that these settings are applied after any phy-specific fixup from
> phy_fixup_list (see phy_init_hw() from drivers/net/phy/phy_device.c),
>@@ -57,16 +58,6 @@ KSZ9031:
> 
> Examples:
> 
>-	/* Attach to an Ethernet device with autodetected PHY */
>-	&enet {
>-		rxc-skew-ps = <3000>;
>-		rxdv-skew-ps = <0>;
>-		txc-skew-ps = <3000>;
>-		txen-skew-ps = <0>;
>-		status = "okay";
>-	};
>-
>-	/* Attach to an explicitly-specified PHY */
> 	mdio {
> 		phy0: ethernet-phy@0 {
> 			rxc-skew-ps = <3000>;


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html