netdev - Re: [PATCH net-next v3] net: Add fib rules at vrf device create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5668A592.3080104@cumulusnetworks.com>
Date:	Wed, 9 Dec 2015 15:05:06 -0700
From:	David Ahern <dsa@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, shm@...ulusnetworks.com,
	roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next v3] net: Add fib rules at vrf device create

On 12/9/15 1:13 PM, David Miller wrote:
> The new attributes make things more complex, because ever _VALID_ tool
> much accomodate the existing situation and be able to perform all of
> the commands above if they are executed on an older kernel.
>
> So the new attributes make things worse, not better.

Dave, how does this make it more complex - beyond the complexity of 
giving a user choices?

If a user wants to install rules directly go for it. That path works 
fine. That covers whatever user base has popped up over the last 38 days 
for the IPv4 support in v4.3 and who ever starts on v4.4 with IPv6 support.

With this change if a user wants the driver to take care of the details 
it can -- by the user asking for the driver to deal with the details.

The 2 options peacefully co-exist.

>
> I will ignore all further attempts to find schemes automate the rule
> and route additions, because it is simply the wrong way forward.

You want to say I failed by not including this in the first patch set - 
fine blame accepted. The initial patches focused on core infrastructure 
to enable VRF support in Linux -- a subject which has proved tough 
enough over the past 15 years.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html