netdev - Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151209224306.GA5082@electric-eye.fr.zoreil.com>
Date:	Wed, 9 Dec 2015 23:43:06 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Corinna Vinschen <vinschen@...hat.com>
Cc:	netdev@...r.kernel.org,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>
Subject: Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not
 set

Corinna Vinschen <vinschen@...hat.com> :
[...]
> This patch is supposed to fix this behaviour.  If LanWake is 0, the
> function now returns 0.  Thus ethtool correctly reports "Wake-on: d".

Can you turn it into a DMI controlled one (something like
drivers/net/ethernet/marvell/skge.c use of dmi_check_system) in order to
avoid a global change of behavior ?

Btw it's probably time to emit some warning during driver probe if wol
bits are not consistent with LanWake.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html