netdev - Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151208.212014.293664653825079141.davem@davemloft.net>
Date:	Tue, 08 Dec 2015 21:20:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	jesse@...nel.org, linville@...driver.com, netdev@...r.kernel.org,
	jesse@...ira.com, kernel-team@...com
Subject: Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

From: Tom Herbert <tom@...bertland.com>
Date: Tue, 8 Dec 2015 16:11:56 -0800

> I thought about a TLV implementation but there is no base support in
> the kernel for it. It would be great if you could implement the TLV
> loop. Honestly, though, I'm still very leery of the processing
> overhead associated with TLVs in the critical data path. In the
> worst case of RCO we would need to fish for the RCO option though
> the TLV list in both the GRO and normal path for each packet. If the
> TLV lists are long then performance may be negatively affected
> mitigating the value of RCO (needs to be measured).

Open ended TLVs are to me likened to an attack vector waiting to
happen, for the reasons Tom listed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html