netdev - Re: rhashtable: Remove unnecessary wmb for future

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151208.224708.473911814887888793.davem@davemloft.net>
Date:	Tue, 08 Dec 2015 22:47:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	tgraf@...g.ch, eric.dumazet@...il.com, josh@...htriplett.org,
	paulmck@...ux.vnet.ibm.com, netdev@...r.kernel.org
Subject: Re: rhashtable: Remove unnecessary wmb for future_tbl

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 8 Dec 2015 17:09:04 +0800

> The patch 9497df88ab5567daa001829051c5f87161a81ff0 ("rhashtable:
> Fix reader/rehash race") added a pair of barriers.  In fact the
> wmb is superfluous because every subsequent write to the old or
> new hash table uses rcu_assign_pointer, which itself carriers a
> full barrier prior to the assignment.
> 
> Therefore we may remove the explicit wmb.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html