netdev - Re: [PATCH iproute2] libnetlink: don't confuse variables in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 08:49:29 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] libnetlink: don't confuse variables in
 rtnl_talk()

On Thu,  3 Dec 2015 17:13:48 +0100
Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:

> There is two variables named 'len' in rtnl_talk. In fact, commit
> c079e121a73a didn't work. For example, it was possible to trigger
> a seg fault with this command:
> $ ip link set gre2 type ip6gre hoplimit 32
> 
> Let's rename the argument len to maxlen.
> 
> Fixes: c079e121a73a ("libnetlink: add size argument to rtnl_talk")
> Reported-by: Thomas Faivre <thomas.faivre@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied, thanks, Not sure why compiler isn't catching this.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html