netdev - Re: [PATCH net] sfc: only use RSS filters if we're using RSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151210.130622.228718339897846404.davem@davemloft.net>
Date:	Thu, 10 Dec 2015 13:06:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bkenward@...arflare.com
Cc:	linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sfc: only use RSS filters if we're using RSS

From: Bert Kenward <bkenward@...arflare.com>
Date: Thu, 10 Dec 2015 13:30:08 +0000

> Without this filter insertion on a VF would fail if only one channel
> was in use. This would include the unicast station filter and therefore
> no traffic would be received.
> 
> Signed-off-by: Bert Kenward <bkenward@...arflare.com>
> ---
>  drivers/net/ethernet/sfc/ef10.c  | 23 +++++++++++------------
>  drivers/net/ethernet/sfc/efx.h   |  5 +++++
>  drivers/net/ethernet/sfc/farch.c |  2 +-
>  3 files changed, 17 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index c4a0e8a..368e98e 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -3309,7 +3309,7 @@ static int efx_ef10_filter_remove_internal(struct efx_nic *efx,
>  
>  		new_spec.priority = EFX_FILTER_PRI_AUTO;
>  		new_spec.flags = (EFX_FILTER_FLAG_RX |
> -				  EFX_FILTER_FLAG_RX_RSS);
> +			(efx_rss_enabled(efx) ? EFX_FILTER_FLAG_RX_RSS : 0));

This was indented properly before your change, please don't damage the indentation
like this.  There must be 4 TAB characters and 2 SPACE characters on that
second line of the assignment so that the first character is precisely at the
first column after the openning parenthesis of the first line.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html