netdev - Re: brcmfmac: only lock and unlock fws if fws is not null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151211111440.67B29141A65@smtp.codeaurora.org>
Date:	Fri, 11 Dec 2015 11:14:40 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Colin Ian King <colin.king@...onical.com>
Cc:	kernel-tram@...ts.ubuntu.com, Brett Rudley <brudley@...adcom.com>,
	Arend van Spriel <arend@...adcom.com>,
	Franky Lin <frankyl@...adcom.com>,
	Hante Meuleman <meuleman@...adcom.com>,
	Pieter-Paul Giesberts <pieterpg@...adcom.com>,
	Arnd Bergmann <arnd@...db.de>, linux-wireless@...r.kernel.org,
	brcm80211-dev-list@...adcom.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: brcmfmac: only lock and unlock fws if fws is not null


> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a null ptr check for fws to set bcmc_credit_check, however,
> there a lock and unlock on fws should only performed if fwts is
> also not null to also avoid a potential null pointer deference.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Acked-by: Arend van Spriel <arend@...adcom.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html