netdev - Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 20:21:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lucien.xin@...il.com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCHv2 net-next] ipv6: allow routes to be configured with
 expire values

From: Xin Long <lucien.xin@...il.com>
Date: Thu, 10 Dec 2015 00:27:53 +0800

> Add the support for adding expire value to routes,  requested by
> Tom Gundersen <teg@...m.no> for systemd-networkd, and NetworkManager
> wants it too.
> 
> add it by using the field rta_expires of rta_cacheinfo
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

This is the wrong way to do this.

Currently we only ever dump rta_cacheinfo values to the user.

If we use it to set things, we have to completely consider every
member of that structure as potentially having meaning either
intended by the user or choosen by us in the future.

Therefore it is a poor choice to start using for specifying the
expires value, and some other mechanism such as a new RTNETLINK
attribute, should be used for this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html