netdev - Re: [PATCH net 1/2] xfrm: add rcu grace period in xfrm_policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 19:22:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	steffen.klassert@...unet.com
Cc:	edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] xfrm: add rcu grace period in
 xfrm_policy_destroy()

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Thu, 10 Dec 2015 13:34:22 +0100

> On Tue, Dec 08, 2015 at 10:58:29PM -0500, David Miller wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>> Date: Tue,  8 Dec 2015 07:22:01 -0800
>> 
>> > We will soon switch sk->sk_policy[] to RCU protection,
>> > as SYNACK packets are sent while listener socket is not locked.
>> > 
>> > This patch simply adds RCU grace period before struct xfrm_policy
>> > freeing, and the corresponding rcu_head in struct xfrm_policy.
>> > 
>> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> 
>> I'll give Steffen an opportunity to review these two patches.
> 
> Looks ok and survived some tests with socket policies.
> 
> If you want to take these direct into the net tree:
> 
> Acked-by: Steffen Klassert <steffen.klassert@...unet.com>

Thanks! I just did exactly that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html