netdev - Re: [PATCH 2/2] netcp: add more _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 19:35:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	netdev@...r.kernel.org, w-kwok2@...com, m-karicheri2@...com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] netcp: add more __le32 annotations

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 08 Dec 2015 16:32:59 +0100

> The handling of epib and psdata remains a bit unclear in the driver,
> as we access the same fields both as CPU-endian and through DMA
> from the device.
> 
> Sparse warns about this:
> ti/netcp_core.c:1147:21: warning: incorrect type in assignment (different base types)
> ti/netcp_core.c:1147:21:    expected unsigned int [usertype] *[assigned] epib
> ti/netcp_core.c:1147:21:    got restricted __le32 *<noident>
> 
> This uses __le32 types in a few places and uses __force where the code
> looks fishy. The previous patch should really have produced the correct
> behavior, but this second patch is needed to shut up the warnings about
> it. Ideally it would be slightly rewritten to not need those casts,
> but I don't dare do that without access to the hardware for proper
> testing.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html