netdev - Re: [PATCH net] bnx2x: Prevent FW assertion when using Vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566D62C6.8050004@cogentembedded.com>
Date:	Sun, 13 Dec 2015 15:21:26 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Cc:	Ariel Elior <Ariel.Elior@...gic.com>
Subject: Re: [PATCH net] bnx2x: Prevent FW assertion when using Vxlan

Hello.

On 12/13/2015 10:49 AM, Yuval Mintz wrote:

> FW has a rare corner case in which a fragmented packet using lots
> of frags would not be linearized, causing the FW to assert while trying
> to transmit the packet.
>
> To prevent this, we need to make sure the window of fragements containing
> MSS worth of data contains 1 BD less than for regular packets due to
> the additional parsing BD.
>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@...gic.com>
> ---
> Hi Dave,
>
> Please consider applying this to `net'.
>
> Thanks,
> Yuval
> ---
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 22 +++++++++++++---------
>   1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index f8d7a2f..3718362 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -3430,25 +3430,29 @@ static u32 bnx2x_xmit_type(struct bnx2x *bp, struct sk_buff *skb)
>   	return rc;
>   }
>
> -#if (MAX_SKB_FRAGS >= MAX_FETCH_BD - 3)
> +/* VXLAN: 4 = 1 (for linear data BD) + 3 (2 for PBD and last BD) */
> +#define BNX2X_NUM_VXLAN_TSO_WIN_SUB_BDS         4
> +
> +/* Regular: 3 = 1 (for linear data BD) + 2 (for PBD and last BD) */
> +#define BNX2X_NUM_TSO_WIN_SUB_BDS               3
> +
> +#if (MAX_SKB_FRAGS >= MAX_FETCH_BD - BDS_PER_TX_PKT)
>   /* check if packet requires linearization (packet is too fragmented)
>      no need to check fragmentation if page size > 8K (there will be no
>      violation to FW restrictions) */
>   static int bnx2x_pkt_req_lin(struct bnx2x *bp, struct sk_buff *skb,
>   			     u32 xmit_type)
>   {
> -	int to_copy = 0;
> -	int hlen = 0;
> -	int first_bd_sz = 0;
> +	int first_bd_sz = 0, num_tso_win_sub = BNX2X_NUM_TSO_WIN_SUB_BDS;
> +	int to_copy = 0, hlen = 0;
>
> -	/* 3 = 1 (for linear data BD) + 2 (for PBD and last BD) */
> -	if (skb_shinfo(skb)->nr_frags >= (MAX_FETCH_BD - 3)) {
> +	if (xmit_type & XMIT_GSO_ENC)
> +			num_tso_win_sub = BNX2X_NUM_VXLAN_TSO_WIN_SUB_BDS;

    Indented too much.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html