netdev - Re: [PATCH ]net: sched/cls_flow.c : allow nfct-* keys work on ingress interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566D7A46.5090008@mojatatu.com>
Date:	Sun, 13 Dec 2015 09:01:42 -0500
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Igor Gavrilov <i.o.gavrilov@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH ]net: sched/cls_flow.c : allow nfct-* keys work on ingress
 interfaces

Hi Igor,

On 15-12-11 04:55 AM, Igor Gavrilov wrote:
> Improved CTTUPLE macro with code from sched/act_connmark.c, so it be
> able to get unNATed addresses from nf_conntrack.
>

1) Question: Have you tested the patch or you just cutnpasted
from connmark.c? By inspection the patch looks ok technically
but if you havent tested, please verify it.
2)The macros have indentation issues around
if (ct == NULL) {} else { }
just use the proper indent rules.

3) Please use proper formatting on submitting patches (such as putting
the From at the top etc). Look at:
Maybe you should use git facilities?

If you meet all the above requirements, please resubmit and
add my Acked-by

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html