netdev - Re: [PATCH net] net: add validation for the socket syscall protocol argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2015 14:32:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: add validation for the socket syscall
 protocol argument

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 14 Dec 2015 17:17:49 +0100

> diff --git a/net/socket.c b/net/socket.c
> index 456fadb..d2f3d49 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -1098,6 +1098,9 @@ int __sock_create(struct net *net, int family, int type, int protocol,
>  		return -EAFNOSUPPORT;
>  	if (type < 0 || type >= SOCK_MAX)
>  		return -EINVAL;
> +	/* upper bound should be tested by per-protocol .create callbacks */
> +	if (protocol < 0)
> +		return -EINVAL;
>  

Please get rid of this part of your patch and resubmit, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html