netdev - Re: [PATCH net] stmmac: dwmac-sunxi: Call exit cleanup function in probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151214.161218.2057176608170714361.davem@davemloft.net>
Date:	Mon, 14 Dec 2015 16:12:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	wens@...e.org
Cc:	peppe.cavallaro@...com, maxime.ripard@...e-electrons.com,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, manabian@...il.com
Subject: Re: [PATCH net] stmmac: dwmac-sunxi: Call exit cleanup function in
 probe error path

From: Chen-Yu Tsai <wens@...e.org>
Date: Fri, 11 Dec 2015 18:03:49 +0800

> dwmac-sunxi has 2 callbacks that were called from stmmac_platform as
> part of the probe and remove sequences.
> 
> Ater the conversion of dwmac-sunxi into a standalone platform driver,
> the .init function is called before calling into the stmmac driver
> core, but .exit is not called to clean up if stmmac returns an error.
> 
> This patch fixes the probe error path. This properly cleans up and
> releases resources when the driver core fails to probe.
> 
> Cc: Joachim Eastwood <manabian@...il.com>
> Fixes: 9a9e9a1edee8 ("stmmac: dwmac-sunxi: turn setup callback into a
> 		      probe function")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html