netdev - Re: [PATCH] sh_eth: uninline sh_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151214.162555.1844850396449382434.davem@davemloft.net>
Date:	Mon, 14 Dec 2015 16:25:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	ben.hutchings@...ethink.co.uk
Subject: Re: [PATCH] sh_eth: uninline sh_eth_{write|read}()

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Sun, 13 Dec 2015 01:44:50 +0300

> Commit 3365711df024 ("sh_eth: WARN on access to a register not implemented in
> in  a particular chip") added WARN_ON() to sh_eth_{read|write}(), thus making
> it  unacceptable for these functions to be *inline* anymore. Remove *inline*
> and move the functions from the header to the driver itself. Below   is our
> code economy with ARM gcc 4.7.3:
> 
> $ size drivers/net/ethernet/renesas/sh_eth.o{~,}
>    text	   data	    bss	    dec	    hex	filename
>   32489	   1140	      0	  33629	   835d	drivers/net/ethernet/renesas/sh_eth.o~
>   25413	   1140	      0	  26553	   67b9	drivers/net/ethernet/renesas/sh_eth.o
> 
> Suggested-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html