netdev - Re: [PATCH net] netlink: fix boolean evaluation on bound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450115411.8474.3.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 14 Dec 2015 09:50:11 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org
Subject: Re: [PATCH net] netlink: fix boolean evaluation on bound

On Mon, 2015-12-14 at 18:27 +0100, Hannes Frederic Sowa wrote:

> Otherwise I would recommend adding a "!!" to express that we actually
> want bound set based on the portid value?

Note that compiler already does the !! thing, when you store an integer
into a bool var.

So it definitely is a matter of taste and code readability.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html