netdev - Re: [PATCH v5 4/4] net: diag: Support destroying TCP socketsr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1450199868-93712-1-git-send-email-lorenzo@google.com>
Date:	Wed, 16 Dec 2015 02:17:44 +0900
From:	Lorenzo Colitti <lorenzo@...gle.com>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net, hannes@...essinduktion.org,
	eric.dumazet@...il.com, ek@...gle.com, tom@...bertland.com,
	zenczykowski@...il.com
Subject: Re: [PATCH v5 4/4] net: diag: Support destroying TCP socketsr

Thanks for the reviews. This version fixes a few issues and
addresses Tom's comments on v5. Specifically:

1. As requested by Tom, tcp_abort is no longer behind a config
   option, and now allows the caller to specify the error with
   which to interrupt blocking operations. (The SOCK_DIAG
   codepath to close TCP sockets from userspace always uses
   ECONNABORTED.)

2. Config symbols are checked with "ifdef" not "if".

3. The boolean Kconfig option no longer depends on
   INET_DIAG && (IPV6 || IPV6=n) but only on INET_DIAG

The name of the operation is still SOCK_DESTROY, and the
functions that implement it still have "destroy" in their
name. I'm leaning towards changing this to SOCK_ABORT instead,
both to reduce confusion with e.g., sock_diag_destroy_group,
and because it seems more correct in general, at least for
TCP. Thoughts on the name?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html