netdev - Re: [patch -mainline] qlge: fix a timeout loop in ql_change_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151215.125224.1037822755732556120.davem@davemloft.net>
Date:	Tue, 15 Dec 2015 12:52:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	harish.patil@...gic.com, sudarsana.kalluru@...gic.com,
	Dept-GELinuxNICDev@...gic.com, linux-driver@...gic.com,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch -mainline] qlge: fix a timeout loop in
 ql_change_rx_buffers()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 15 Dec 2015 13:52:36 +0300

> The problem here is that after the loop we test for "if (!i) " but
> because "i--" is a post-op we exit with i set to -1.  I have fixed this
> by changing it to a pre-op instead.  I had to change the starting value
> from 3 to 4 so that we still iterate 3 times.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html